Hi Charles Thank you for your feedback > On Tue, Nov 15, 2016 at 05:09:57AM +0000, Kuninori Morimoto wrote: > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > wm8580 driver doesn't work without CONFIG_I2C anyway. > > Let's depend on it. > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > --- (snip) > Again here the patch looks fine but commit message is a bit > different from the patch, this converts the driver to use > module_i2c_driver as the title of the commit message states but > the body of the commit message seems to imply we are adding a > dependency into the Kconfig which we arn't doing. And about Kconfig, WM8510 already has "depends on I2C" in Kconfig, so, this patch doesn't have such lines. But yes indeed, commit message is not good, I will fix it in v2, thanks. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
