Re: [PATCH] ASoC: pxa: Make static string arrays 'const 'char * const []'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lars-Peter Clausen <lars@xxxxxxxxxx> writes:

> const char * const [] is the preferred type for static string arrays since
> this states explicitly that the individual entries are not going to be
> changed. Due to limitations in the ASoC API it was not possible to use it
> for enum text arrays. Commit 87023ff74 ('ASoC: Declare const properly for
> enum texts') changed this, but most drivers still use 'const char
> * []' as the type for their enum text arrays.
>
> Change these occurrences of 'static * const char * []' to 'static const
> char * const []'.
>
> The conversion was done automatically using the following coccinelle semantic
> patch:
> // <smpl>
> @disable optional_qualifier@
> identifier s;
> @@
>  static
> -const char *
> +const char * const
>  s[] = ...;
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

Hi,

Could you amend your commit message so that checkpatch doesn't complain anymore
? This being done, looks good to me.

Cheers.

--
Robert
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux