> -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: Saturday, November 5, 2016 1:22 AM > To: mengdong.lin@xxxxxxxxxxxxxxx > Cc: alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxx; > liam.r.girdwood@xxxxxxxxxxxxxxx; Shah, Hardik T <hardik.t.shah@xxxxxxxxx>; > Singh, Guneshwor O <guneshwor.o.singh@xxxxxxxxx>; Koul, Vinod > <vinod.koul@xxxxxxxxx>; Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx>; > Lin, Mengdong <mengdong.lin@xxxxxxxxx> > Subject: Re: [PATCH v7 07/11] ASoC: topology: Add support to configure > existing physical DAI links > > On Thu, Nov 03, 2016 at 01:04:27AM +0800, mengdong.lin@xxxxxxxxxxxxxxx > wrote: > > > + name = strlen(cfg->name) ? cfg->name : NULL; > > + stream_name = strlen(cfg->stream_name) ? cfg->stream_name : NULL; > > Please replace these with normal if statements. Also, are we sure that we've > sufficiently audited the input paths to ensure that the strings are always > terminated? Okay. I submitted patch to fix this - ASoC: topology: Check name strings of physical DAI links. This another minor ABI update, just a name change of a field and backward compatible. Thanks again for your review! Mengdong _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
