> -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: Saturday, October 29, 2016 2:51 AM > To: mengdong.lin@xxxxxxxxxxxxxxx > Cc: alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxx; > liam.r.girdwood@xxxxxxxxxxxxxxx; Shah, Hardik T <hardik.t.shah@xxxxxxxxx>; > Singh, Guneshwor O <guneshwor.o.singh@xxxxxxxxx>; Koul, Vinod > <vinod.koul@xxxxxxxxx>; Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx>; > Lin, Mengdong <mengdong.lin@xxxxxxxxx> > Subject: Re: [PATCH v6 02/11] ASoC: topology: Make PCM backward > compatible from ABI v4 > > On Tue, Oct 11, 2016 at 02:36:49PM +0800, mengdong.lin@xxxxxxxxxxxxxxx > wrote: > > > @@ -508,6 +541,10 @@ static void remove_link(struct > snd_soc_component *comp, > > if (dobj->ops && dobj->ops->link_unload) > > dobj->ops->link_unload(comp, dobj); > > > > + kfree(link->name); > > + kfree(link->stream_name); > > + kfree(link->cpu_dai_name); > > + > > list_del(&dobj->list); > > snd_soc_remove_dai_link(comp->card, link); > > kfree(link); > > @@ -1606,7 +1643,8 @@ static int soc_tplg_dai_create(struct soc_tplg > *tplg, > > if (dai_drv == NULL) > > return -ENOMEM; > > > > - dai_drv->name = pcm->dai_name; > > + if (strlen(pcm->dai_name)) > > + dai_drv->name = kstrdup(pcm->dai_name, GFP_KERNEL); > > dai_drv->id = pcm->dai_id; > > > > if (pcm->playback) { > > These appear to be fixes unrelated to the ABI handling? Sorry, they're not related to ABI handling. I'll move them to other patches. Thanks Mengdong _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel