On Tue, Oct 11, 2016 at 02:36:42PM +0800, mengdong.lin@xxxxxxxxxxxxxxx wrote:
> +static int manifest_new_ver(struct soc_tplg *tplg,
> + struct snd_soc_tplg_manifest *src,
> + struct snd_soc_tplg_manifest **manifest)
> +{
> + struct snd_soc_tplg_manifest *dest;
> + struct snd_soc_tplg_manifest_v4 *src_v4;
> +
> + *manifest = NULL;
> +
> + if (src->size != sizeof(*src_v4)) {
> + dev_err(tplg->dev, "ASoC: invalid manifest size\n");
> + return -EINVAL;
> + }
> +
> + dev_warn(tplg->dev, "ASoC: old version of manifest\n");
The way this function is written it's not going to scale to any future
ABI churn, it's not set up to handle multiple versions at all.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
