On Fri, Oct 21, 2016 at 02:18:48PM +0100, Charles Keepax wrote:
> Unfortunately, I seem to have missed a case where an IRQ safe spinlock was
> required, in samsung_i2s_dai_remove, when I fixed up the other calls in
> this patch:
>
> 316fa9e09ad7 ("ASoC: samsung: Use IRQ safe spin lock calls")
>
> This causes a lockdep warning when unbinding and rebinding the audio card:
>
> [ 104.357664] CPU0 CPU1
> [ 104.362174] ---- ----
> [ 104.366692] lock(&(&pri_dai->spinlock)->rlock);
> [ 104.371372] local_irq_disable();
> [ 104.377283] lock(&(&substream->self_group.lock)->rlock);
> [ 104.385259] lock(&(&pri_dai->spinlock)->rlock);
> [ 104.392469] <Interrupt>
> [ 104.395072] lock(&(&substream->self_group.lock)->rlock);
> [ 104.400710]
> [ 104.400710] *** DEADLOCK ***
>
> Fixes: ce8bcdbb61d9 ("ASoC: samsung: i2s: Protect more registers with a spinlock")
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> sound/soc/samsung/i2s.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
