05.10.2016, 00:20, "Maxime Ripard" <maxime.ripard@xxxxxxxxxxxxxxxxxx>: > Hi, > >> +static const struct of_device_id sun8i_codec_of_match[] = { >> + { .compatible = "allwinner,sun8i-a33-codec" }, >> + { .compatible = "allwinner,sun8i-a23-codec" }, > > I thought that the A23 and A33 had different codecs? In that case, it > wouldn't be a good assumption to make Yes. > >> + {} >> +}; >> +MODULE_DEVICE_TABLE(of, sun8i_codec_of_match); >> + >> +static struct platform_driver sun8i_codec_driver = { >> + .driver = { >> + .name = "sun8i-codec", >> + .owner = THIS_MODULE, >> + .of_match_table = sun8i_codec_of_match, >> + }, >> + .probe = sun8i_codec_probe, >> + .remove = sun8i_codec_remove, >> +}; >> +module_platform_driver(sun8i_codec_driver); >> + >> +MODULE_DESCRIPTION("Allwinner A33 (sun8i) codec driver"); >> +MODULE_AUTHOR("huanxin<huanxin@xxxxxxxxxxxxxxxxx>"); > > Those obfuscated email adresses are not really helpful :) This kind of email addresses are kept in many places in mainline kernel. e.g. drivers/mmc/host/sunxi-mmc.c have 'Aaron Maoye <leafy.myeh@xxxxxxxxxxxxxxxxx>' > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > , > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel