Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




26.09.2016 19:08, Mark Brown пишет:
> On Mon, Sep 26, 2016 at 01:35:50PM +0300, Nikita Yushchenko wrote:
> 
>> I doubt that copying 7 lines into error path is better than having a tiny
>> logic with return values, but still here it is.
> 
> Consider what happens if someone wants to change the code... 

I believe that "undo poweron" and "poweroff" sequences still will have
to remain the same. This having two copies of code is more error-prone
than having one.

Nikita
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux