>On 9/8/16, 11:29 AM, "Alexander Shiyan" < shc_work@xxxxxxx > wrote: > ... >>+config SND_SOC_CS4341 >>+tristate "Cirrus Logic CS4341 CODEC" >>+depends on SPI_MASTER >>+select REGMAP_SPI >>+help >>+ Enable support for Cirrus Logic (Crystal) CS4341 CODEC. >>+ >This devices primary interface is I2C. That should be added as well since >i2c is read/write and spi is write only. I can add I2C support, but can not test this. ... >>+snd_soc_update_bits(codec, CS4341_REG_MODE2, CS4341_MODE2_DIF, >>+ bits24 ? CS4341_MODE2_DIF_RJ_24 : >>+ CS4341_MODE2_DIF_RJ_16); >>+break; >>+default: >>+dev_err(codec->dev, "Unsupported DAI format\n"); >>+return -EINVAL; >>+} > >Can we use regmap_update_bits where we can? So you say that regmap_update_bits() is prefferred than snd_soc_update_bits() ? --- _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
