On Thu, Aug 18, 2016 at 09:04:12AM +0800, John Hsu wrote: > On 8/17/2016 5:42 PM, Mark Brown wrote: > > The whole point with raw read is that it isn't reformatting the value. > I post the partial function. The format_val is not valid for our > codec driver and we can't use the regmap_raw_read(). It's the reason > that we need to make the function like regmap_raw_read(). Hrm, and you can't just make raw read work because other users are relying on the native endianness for single reads so bulk_read() then for the actual I/O? At a bare minimum you need to provide comments in the code explaining what's going on, at the minute it looks like something that needs cleaning up.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel