On Mon, 08 Aug 2016 14:19:50 +0200, Takashi Sakamoto wrote: > > On Aug 8 2016 16:09, Takashi Iwai wrote: > > It's better to pass a snd_seq_client pointer to this function and > > evaluate client->port in the function instead of referencing to > > client->port from each caller. > > ? > > I don't understand to what you addressed. Neither snd_seq_do_ioctl() > and snd_seq_kernel_client_ctl() have differences about port > referencing. Put in this way: why did you change seq_call_port_ioctl() to take an clientid integer instead of client pointer? Due to this change, each caller has to deduce the client number by referencing client->number. Which merit does it give at all? Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
