Re: [PATCH 11/39] ALSA: seq: optimize system_info function to new design

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 8 2016 16:50, Takashi Iwai wrote:
On Mon, 08 Aug 2016 09:04:55 +0200,
Takashi Iwai wrote:

On Sun, 07 Aug 2016 11:48:47 +0200,
Takashi Sakamoto wrote:

In former commit, actual operations of each ioctl command get argument
in kernel space. Copying from/to user space is performed outside of
the function.

This commit optimizes to the new design.

Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

While it's OK to split to small patches if you prefer, you don't have
to do so.  Basically all the rest are doing the same thing (strip
copy_*_user() and replace to the pointer accesses), and it's rather
boring to read repeated mails.

BTW, I'm afraid that the patch series breaks bisection.
We need to consider rearranging the changes if we want to keep
bisectionability.

As long as it's possible. But in this case, it's difficult. The relation between ioctl table and each functions is one to N. If we change them in one patch, the size is quite large (and alsa-project.org will skip it to deliver.). It's unavoidable.


Regards

Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux