On Aug 2 2016 21:22, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> > Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx> > --- > sound/firewire/bebob/bebob.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c > index f7e2cbd..ec67fc6 100644 > --- a/sound/firewire/bebob/bebob.c > +++ b/sound/firewire/bebob/bebob.c > @@ -22,11 +22,11 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; > static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; > static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; > > -module_param_array(index, int, NULL, 0444); > +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(index, "card index"); > -module_param_array(id, charp, NULL, 0444); > +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(id, "ID string"); > -module_param_array(enable, bool, NULL, 0444); > +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(enable, "enable BeBoB sound card"); > > static DEFINE_MUTEX(devices_mutex); _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
