Re: [PATCH v2 0/5] topology: Enhance support for private data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jul 15 2016 21:17, mengdong.lin@xxxxxxxxxxxxxxx wrote:
> From: Mengdong Lin <mengdong.lin@xxxxxxxxxxxxxxx>
> 
> There is no ABI change in this series.
> 
> We finished verification on latest Intel platforms. There will be 4 or 5
> series. Later series will come with some ABI update for topology. The size
> check on ABI objects in current ASoC kernel will detect possible ABI
> version mismatch between user space and kernel
> 
> History:
> v2: fix compiler warnings. There are 2 warnings left in topology/pcm.c
>     that are not caused by this series and will be fixed in later patches.
> 
> Mengdong Lin (5):
>   topology: An element can refer to multipe data sections in text conf
>     file
>   topology: Merge lookup for data reference into tplg_copy_data()
>   topology: Change uuid value to 16 separate characters in text conf
>     file
>   topology: Parse vendor private data for manifest
>   topology: Tuple type can have an extenstion
> 
>  include/topology.h        |  69 ++++++++++-
>  src/topology/ctl.c        |  52 +++-----
>  src/topology/dapm.c       |  17 ++-
>  src/topology/data.c       | 307 ++++++++++++++++++++++++++++++++++++++--------
>  src/topology/elem.c       |   4 +
>  src/topology/parser.c     |  28 ++++-
>  src/topology/tplg_local.h |  15 ++-
>  7 files changed, 395 insertions(+), 97 deletions(-)

Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

Current implementation of ALSA SoC part in kernel has no call
corresponding to sys_ioctl(SNDRV_CTL_IOCTL_ELEM_ADD) or something like
that, thus I recommend you to drop this line by an additional patch:
http://git.alsa-project.org/?p=alsa-lib.git;a=blob;f=src/topology/ctl.c;h=b948ac021ceecc116bc1087075743243e4b14055;hb=HEAD#l44


Regards

Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux