On Mon, 06 Jun 2016 19:07:43 +0200, Clive Messer wrote: > > On Mon, 2016-06-06 at 14:59 +0200, Takashi Iwai wrote: > > Well, it'd be more convincing if you actually show the reduction of > > the code after this patch in the current tree. The number speaks > > more than words. > > pcm5102a codec driver with 352k8/384k defines patch... > > https://github.com/DigitalDreamtimeLtd/linux/commit/83669837232018909e97623588de355fe072546b > > versus, with KNOT and startup constraint... > > https://github.com/DigitalDreamtimeLtd/linux/commit/06a68d757ff641b94aeb8b6385312923c5a86e18 I'm asking about "the current tree". In other words, after applying your patch, how many codes in my current tree can be reduced? In the case of such a cleanup patch, the interesting part isn't in the patch itself -- which is often a trivial change -- but rather the end result after the change. You can see the analogy in dietary foods: what's more convincing is how many pounds are cut, not which fruit to eat. So, please prove the cleanup results as patches, and send together with your patch as a complete patchset. Then it'll become more convincing. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
