Re: [PATCH 11/49] ASoC: simple-card-core: add asoc_simple_card_parse_card_widgets()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mark

> > +int asoc_simple_card_parse_card_widgets(struct snd_soc_card *card,
> > +					char *prefix)
> > +{
> > +	struct device_node *np = card->dev->of_node;
> > +	char prop[128];
> > +	int ret = 0;
> > +
> > +	snprintf(prop, sizeof(prop), "%swidgets", prefix);
> > +
> > +	if (of_property_read_bool(np, prop))
> > +		ret = snd_soc_of_parse_audio_simple_widgets(card, prop);
> > +
> > +	return ret;
> > +}
> > +EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_widgets);
> 
> This seems like an extremely thin wrapper around existing core
> functionality, shouldn't we just be adding the property check into the
> core?

OK, will do in v2
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux