Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 18 May 2016 16:08:12, Mark Brown wrote:
> On Wed, May 18, 2016 at 03:41:29PM +0200, Alexander Stein wrote:
> > In case there is no DAI (yet), do not print an error, this might happen
> > a lot of times. Print a notice instead.
> 
> This is changing *all* error reports which isn't OK.

Well, it's debatable if using dev_err() and then returning EPROBE_DEFER is 
correct either. IMHO if there is an actual error, an error code has to be 
returned and not "well, can't continue now, probe me again later".
At first glance those EPROBE_DEFER are correct as other dependent drivers may 
be probed later, so printing an error in that case seems wrong to me.

Best regards,
Alexander

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux