Re: [PATCH v2 1/2] ASoC: dapm: support user-defined stop condition in dai_get_connected_widgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 14, 2016 at 02:03:18PM +0100, Piotr Stankiewicz wrote:

> + * Optionally, can be supplied with a function acting as a stopping condition.
> + * This function takes the dapm widget currently being examined and the walk
> + * direction as an arguments, and should return an integer, as follows:
> + * - >=0: if the walk is to be stopped (this should indicate the number of
> + *        endpoints the widget has),
> + * - <0 : if the walk is to be continued as normal.

This seems really weird and uncomfortable.  From the naming I would
expect it to be a boolean function and I'm struggling to understand when
it would be useful to report multiple endpoints on a widget (edge
widgets normally being single objects).  The whole counting thing is
mainly a combination of debugging and an artefact of the implementation.
What's the motivation here?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux