Re: [PATCH 2/2] ASoC: wm8985: add support for WM8758

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2016 at 05:54:37PM +0200, Petr Kulhavy wrote:

> +static const struct snd_kcontrol_new wm8758_snd_controls[] = {
> +	SOC_SINGLE("Digital Loopback Switch", WM8985_COMPANDING_CONTROL,
> +		0, 1, 0),

>  static const struct snd_kcontrol_new wm8985_snd_controls[] = {
>  	SOC_SINGLE("Digital Loopback Switch", WM8985_COMPANDING_CONTROL,
>  		0, 1, 0),

Rather than completely duplicating the set of controls it is better to
have one table with all the shared controls and then extra tables for
those that are device specific that are registered in probe, that way
we only define things once.  The wm8904 driver provides an example of
doing this sort of thing.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux