Mark Brown <broonie@xxxxxxxxxx> writes: > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: >> Mark Brown <broonie@xxxxxxxxxx> writes: > >> > I see that, I just don't know why that helps. >> In order to have a clean split between former ac97 bus implementation and this >> new one, I didn't want to include any former ac97 includes, excepting in >> sound/ac97/compat.c. > > It's probably a good idea to articulate some of this in the commit log > then! Fair point, I'll improve that. >> This transition will be easier if the new ac97 code is isolated as much as >> possible from the former code while providing backward compatibility ... hence >> this patch. > > It'd probably have been clearer to me if it were splitting out all the > register definitions rather than just some of them. Euh unless I'm missing something I have splitted out all the ac97 generic registers AFAIK. The only remaining ones are chip specific which I didn't take as they should be in codec specific code and not ac97 generic one. Cheers. -- Robert _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
