On Friday 22 April 2016 05:50 PM, Petr Kulhavy wrote:
> Add SoC nodes for McBSP0 and McBSP1 as well as the corresponding pinmux
> configurations.
>
> Signed-off-by: Petr Kulhavy <petr@xxxxxxxxx>
> ---
> v1: initial
> v2: add missing TC channel in dmas properties (for compatibility with the new EDMA3 binding)
> remove "-audio" postfix from the compatible string
> v3: no change
> v4: no change
>
> arch/arm/boot/dts/da850.dtsi | 45 +++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 44 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 5996e765e59c..708d48e1b6d1 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -148,7 +148,24 @@
> 0xc 0x88888888 0xffffffff
> >;
> };
> -
> + mcbsp0_pins: pinmux_mcbsp0_pins {
> + pinctrl-single,bits = <
> + /* PINMUX2:
> + * CLKS0, DX0, DR0, FSX0
> + * FSR0, CLKX0, CLKR0
> + */
> + 0x8 0x02222220 0xfffffff0
> + >;
> + };
> + mcbsp1_pins: pinmux_mcbsp1_pins {
> + pinctrl-single,bits = <
> + /* PINMUX1:
> + * CLKS1, DX1, DR1, FSX1,
> + * FSR1, CLKX1, CLKR1
> + */
> + 0x4 0x22222220 0xfffffff0
> + >;
> + };
> };
> edma0: edma@01c00000 {
> compatible = "ti,edma3-tpcc";
> @@ -335,6 +352,32 @@
> <&edma0 0 1>;
> dma-names = "tx", "rx";
> };
> +
> + mcbsp0: mcbsp@1d10000 {
> + compatible = "ti,da850-mcbsp";
> + reg = <0x00110000 0x1000>,
> + <0x00310000 0x1000>;
The node name should be sound@110000
sound because use of generic names is preferred (I know the mcasp has
got this wrong). And the unit address after the @ should match the reg
property. I would also lose the unnecessary 0s in the reg address.
Thanks,
Sekhar
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
