On Fri, Apr 29, 2016 at 11:05:51AM +0200, Takashi Iwai wrote:
> > +int snd_hdac_ext_bus_link_get(struct hdac_ext_bus *ebus,
> > + struct hdac_ext_link *link)
> > +{
> > + int ret = 0;
> > +
> > + spin_lock(&ebus->lock);
> > +
> > + /*
> > + * if we move from 0 to 1, count will be 1 so power up this link
> > + * as well, also check the dma status and trigger that
> > + */
> > + if (++link->ref_count == 1) {
> > + if (!ebus->cmd_io) {
> > + snd_hdac_bus_init_cmd_io(&ebus->bus);
>
> Calling this function inside a spinlock is wrong.
> It should be mutex instead.
Yes I looked at it's usage, we should do a mutex here, will send an update
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
