Re: [PATCH v5 0/4] Propagate errors out from compressed streams

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 20 Apr 2016 14:39:59 +0200,
Charles Keepax wrote:
> 
> If the DSP suffers an unrecoverable error, the driver likely
> knows about this, however the framework may not get informed
> because errors returned from pointer requests are ignored within
> the framework.
> 
> Things work out fine if user-space is doing a read as reads
> return error status back to user-space so the user can find out
> that things have gone bad. However, if user-space is doing an
> avail request there is no path for the error to come back up to
> user-space. The pointer request returns zero available data, so a
> read never happens and we basically just end up sitting waiting
> for data on a stream that we know full well has died.
> 
> This patch set attempts to address this and ensure that errors
> are fully propagated to user-space and we don't ever end up wait
> for data that will never come.
> 
> Changes since v4:
>  - Fix issue noticed by Vinod whereby the error state was being
>    overwritten when snd_compr_stop was called
> 
> It might be easiest to put the ASoC changes through Mark's tree
> as there are some merge conflicts otherwise, as such I have based
> this series on Mark's tree.

If it goes through Mark's tree, feel free to take my ack to these
patches:
  Acked-by: Takashi Iwai <tiwai@xxxxxxx>

Or if it's easier through my tree, let me know.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux