> On Apr 18, 2016, at 3:35 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Fri, Apr 15, 2016 at 11:30:59AM -0700, Jeremy McDermond wrote: >> The TLV320AIC32x4 support the control channel over either SPI or I2C. >> Added the proper interfacing with regmap to make the driver able to >> handle either possibility. >> >> Signed-off-by: Jeremy McDermond <nh6z@xxxxxxxx> >> --- >> sound/soc/codecs/Kconfig | 5 +- >> sound/soc/codecs/tlv320aic32x4.c | 181 +++++++++++++++++++++++++++++++++++---- >> 2 files changed, 165 insertions(+), 21 deletions(-) > > Instead of putting everything in one file please split the driver so it > has separate core and I2C modules and then add a SPI module like we do > for newer drivers. No problem. Thanks Mark. Would you like the separation of the I2C code to be in a separate patch set, or is one patch set with two separate patches fine? >> config SND_SOC_TLV320AIC32X4 >> - tristate >> + tristate "Texas Instruments TLV320AIC32x4 CODECs" >> + depends on SND_SOC_I2C_AND_SPI > > Making the driver directly user selectable is a separate change and > should be in a separate patch. I should have reviewed my submission better. This was for testing only. Sorry about that. -- Jeremy McDermond (NH6Z) Xenotropic Systems mcdermj@xxxxxxxxxxxxxx _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
