Re: [PATCH] ALSA: hda/realtek - Add ALC3234 headset mode for Optiplex 9020m

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Apr 2016 13:56:34 +0200,
Bastien Nocera wrote:
> 
> On Mon, 2016-04-18 at 13:20 +0200, Takashi Iwai wrote:
> > On Mon, 18 Apr 2016 12:02:59 +0200,
> > Bastien Nocera wrote:
> > > 
> > > 
> > > On Mon, 2016-04-18 at 11:40 +0200, Takashi Iwai wrote:
> > > > 
> > > > On Mon, 18 Apr 2016 11:10:42 +0200,
> > > > Bastien Nocera wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > The Optiplex 9020m with Haswell-DT processor needs a quirk for
> > > > > the
> > > > > headset jack at the front of the machine to be able to use
> > > > > microphones.
> > > > > 
> > > > > A quirk for this model was originally added in 3127899, but
> > > > > c77900e
> > > > > removed it in favour of a more generic version.
> > > > > 
> > > > > Unfortunately, pin configurations can changed based on
> > > > > firmware/BIOS
> > > > > versions, and the generic version doesn't have any effect on
> > > > > newer
> > > > > versions of the machine/firmware anymore.
> > > > > 
> > > > > With help from David Henningsson <diwic@xxxxxxxxxx>
> > > > > 
> > > > > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx>
> > > > > Tested-by: Bastien Nocera <hadess@xxxxxxxxxx>
> > > > Applied, thanks.
> > > Thanks for the quick response. Can you however fix the typo I made?
> > > 
> > > "pin configurations can changed"
> > > should be
> > > "pin configurations can change"
> > Sorry, too late, it's been already merged and published.
> 
> Yay git :/

If the change were catastrophically buggy, I'd revert or rebase.  But
in this case, it's a not-too-bad typo, so I prefer leaving it.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux