On Fri, Apr 08, 2016 at 05:09:09AM +0200, Lars-Peter Clausen wrote:
> > + ret = regmap_read(max98371->regmap, MAX98371_VERSION, ®);
> > + if (ret < 0) {
> > + dev_info(&i2c->dev, "device error %d\n", ret);
> > + return ret;
> > + }
> > + dev_info(&i2c->dev, "device version %x\n", reg);
> Drop this, it is just noise in the boot log.
It's generally OK to print information about the actual hardware found
in the system, it can be a helpful diagnostic. Getting all this stuff
into sysfs files would be even better but that doesn't seem to be how we
do things at the minute.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
