On Wed, Mar 30, 2016 at 08:38:42AM +0530, libin.yang@xxxxxxxxxxxxxxx wrote: > From: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > > Make sure per_pin is not NULL before using it. Hi Libin, In the beginning of ctl_put handler this NULL check is already done. Are you supposed to call this set_chmap from other places too? Regards, Subhransu > > Signed-off-by: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > --- > sound/pci/hda/patch_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 4833c7b..c99289d 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -1858,6 +1858,8 @@ static void hdmi_set_chmap(struct hdac_device *hdac, int pcm_idx, > struct hdmi_spec *spec = codec->spec; > struct hdmi_spec_per_pin *per_pin = pcm_idx_to_pin(spec, pcm_idx); > > + if (!per_pin) > + return; > mutex_lock(&per_pin->lock); > per_pin->chmap_set = true; > memcpy(per_pin->chmap, chmap, ARRAY_SIZE(per_pin->chmap)); > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
