Re: [PATCH v2 1/5] Sound: SOC: TAS571x: added missing register literals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 29, 2016 at 09:39:34AM +0200, Petr Kulhavy wrote:

> The list of TAS571x registers was incomplete.
> Added the missing register definitions up to register 0x25

According to the driver the device has registers up to 0xff?

>  /* device registers */
> +#define TAS571X_CLK_CTRL_REG		0x00
> +#define TAS571X_DEV_ID_REG		0x01
> +#define TAS571X_ERR_STATUS_REG		0x02
> +#define TAS571X_SYS_CTRL_1_REG		0x03

These look like volatile registers but the device has a register cache
and we're not adding a list of volatile registers (or readable registers
for that matter).

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux