On Thu, 17 Mar 2016 13:22:29 +0100, Jyri Sarha wrote: > > Add IEC958 channel status helper that gets the audio properties from > snd_pcm_hw_params instead of snd_pcm_runtime. This is needed to > produce the channel status bits already in audio stream configuration > phase. > > Signed-off-by: Jyri Sarha <jsarha@xxxxxx> This patch looks almost good to me, but... > @@ -71,6 +59,7 @@ int snd_pcm_create_iec958_consumer(struct snd_pcm_runtime *runtime, u8 *cs, > IEC958_AES4_CON_MAX_WORDLEN_24; > break; > case 24: > + case 32: /* Assume 24-bit width for 32-bit samples. */ > ws = IEC958_AES4_CON_WORDLEN_24_20 | > IEC958_AES4_CON_MAX_WORDLEN_24; > break; ... this change is silently slipped in. It should be mentioned in the changelog, or split to another patch, as this is basically an orthogonal change. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
