On Tue, 22 Mar 2016 06:10:23 +0100, han.lu@xxxxxxxxx wrote: > > From: "Lu, Han" <han.lu@xxxxxxxxx> > > 1. Clean structure, use general function to replace local processes. Your patches have no description "why" at all, so I don't know why I need to merge them, either. It's one of most important information. Please explain why you need the change in each patch description to convince readers. > 2. Add tinyalsa support, configure will read environment and decide to > link to ALSA lib or tinyalsa lib. It's not good to choose tinyalsa forcibly whenever it's found. Then there is no way to build alsabat with alsa-lib on a system that have both libraries installed. Better to add configure option to choose the backend, not only detecting it. thanks, Takashi > > Lu, Han (6): > alsabat: clean file process on capture thread loop > alsabat: use common wav process function in playback loop > alsabat: clean return value of playback and capture loops > alsabat: use common data generator function > alsabat: move alsa process to alsa.c > alsabat: add tinyalsa support > > bat/Makefile.am | 12 +- > bat/alsa.c | 217 +++++++++++--------------- > bat/alsabat.1 | 3 + > bat/bat.c | 58 +++---- > bat/common.c | 68 +++++++++ > bat/common.h | 17 ++- > bat/signal.c | 13 +- > bat/tinyalsa.c | 460 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > bat/tinyalsa.h | 20 +++ > configure.ac | 4 + > 10 files changed, 698 insertions(+), 174 deletions(-) > create mode 100644 bat/tinyalsa.c > create mode 100644 bat/tinyalsa.h > > -- > 2.5.0 > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
