Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 16, 2016 at 07:17:51PM +0800, Harry Pan wrote:

> Conflicts:
> 	sound/soc/soc-dapm.c

Don't include noise like this in upstream submissions.

> +	if (!strcmp(cmpnt->name, "snd-soc-dummy"))
> +		return 0;
> +

This doesn't make much sense and is going to be very fragile.  We
should either make the dummy component look like other components or
make the code cope with them as they stand, that way we don't have
random undocumented special cases scattered through the code.  Probably
it's better to make the dummy component look like others.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux