On Thu, Mar 03, 2016 at 02:42:42PM +0800, Zidan Wang wrote: > This is the initial imx-wm8958 device-tree-only machine driver working > with fsl_sai driver. This sound card has three dai link, HIFI, VOICE > and BT dai. HIFI dai link will support codec master and slave mode. > VOICE an BT dai link have dummy cpu dai, and just support codec > master mode. Still dummy? > +++ b/Documentation/devicetree/bindings/sound/imx-audio-wm8958.txt > @@ -0,0 +1,49 @@ > +Freescale i.MX audio complex with WM8958 codec > + > +Required properties: > + > + - compatible : "fsl,imx-audio-wm8958" > + > + - model : The user-visible name of this sound complex > + > + - cpu-dai : The phandle of an CPU DAI controller One of my previous suggestions was something like this: cpu-dai1 : The phandle of an CPU DAI controller for AIF1 cpu-dai2 : The phandle of an CPU DAI controller for AIF2 cpu-dai3 : The phandle of an CPU DAI controller for AIF3 > + data->card.num_links = DAI_LINK_NUM; > + data->card.dai_link = data->dai_link; Then, rather than hard coding the total DAI link number and creating useless dummy links, you may create the links dynamically according to the presence of the three properties above. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel