Re: [PATCH] Add a quirk for Plantronics DA45

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm sorry, maybe I've misunderstood something. As far as I understood https://www.kernel.org/doc/Documentation/SubmittingPatches, it should be sufficient to close the patch mail with Signed-off-by: Dennis Kadioglu <denk@xxxxxxxx>, which I did in my second mail (see below). Is there anything else I've missed?

----- Ursprüngliche Mail -----
Von: "Takashi Iwai" <tiwai@xxxxxxx>
An: "denk" <denk@xxxxxxxx>
CC: alsa-devel@xxxxxxxxxxxxxxxx
Gesendet: Dienstag, 1. März 2016 11:23:19
Betreff: Re:  [PATCH] Add a quirk for Plantronics DA45

On Tue, 01 Mar 2016 11:19:48 +0100,
denk wrote:
> 
> As I've got no response by now, I would like to politely ask, if the patch can be accepted now, after the requested modifications?

I thought I replied you, suggesting to give a proper sign-off line.
Without your own sign-off, we can't merge any patch from you.
See Documentation/SubmittingPatches for details.

So, please resubmit with it.


thanks,

Takashi


> 
> Thank you very much and best
> denk
> 
> ----- Ursprüngliche Mail -----
> Von: "denk" <denk@xxxxxxxx>
> An: alsa-devel@xxxxxxxxxxxxxxxx
> Gesendet: Freitag, 19. Februar 2016 14:01:02
> Betreff: [PATCH] Add a quirk for Plantronics DA45
> 
> Plantronics DA45 does not support reading the sample rate which leads to many lines of "cannot get freq at ep 0x4" and "cannot get freq at ep 0x84". This patch adds the USB ID of the DA45 to quirks.c and avoids those error messages.
> 
> ---
>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 2585c17..5b03296 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1123,6 +1123,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>         case USB_ID(0x045E, 0x076F): /* MS Lifecam HD-6000 */
>         case USB_ID(0x045E, 0x0772): /* MS Lifecam Studio */
>         case USB_ID(0x045E, 0x0779): /* MS Lifecam HD-3000 */
> +       case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>         case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>         case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
>         case USB_ID(0x21B4, 0x0081): /* AudioQuest DragonFly */
> ---
> Signed-off-by: Dennis Kadioglu <denk@xxxxxxxx>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux