On Mon, 29 Feb 2016 16:05:20 +0100,
Thomas Klausner wrote:
>
> From: Thomas Klausner <wiz@xxxxxxxxxx>
>
> ---
> include/sound/asound.h | 4 ++--
Sorry, this is no-go. The files in include/sound/* are basically
copies of Linux ABI. So, all these files must not be modified in
alsa-lib side. And, using __kernel_off_t there is in purpose -- to
distinguish from the user-space off_t.
That said, the best workaround for these files are to provide the
compatible typedefs.
OTOH, the code changes in include/pcm.h and src/pcm/* are acceptable,
in general, but I still hesitate to apply it, so far. If it's only
about portability, we may wrap it with a few typedefs instead of
touching so many lines. And it would bring any other real benefit?
It's the question...
thanks,
Takashi
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/sound/asound.h b/include/sound/asound.h
> index a82108e..4f2202f 100644
> --- a/include/sound/asound.h
> +++ b/include/sound/asound.h
> @@ -415,7 +415,7 @@ struct snd_pcm_sw_params {
>
> struct snd_pcm_channel_info {
> unsigned int channel;
> - __kernel_off_t offset; /* mmap offset */
> + off_t offset; /* mmap offset */
> unsigned int first; /* offset to first sample in bits */
> unsigned int step; /* samples distance in bits */
> };
> @@ -884,7 +884,7 @@ struct snd_ctl_elem_info {
> snd_ctl_elem_type_t type; /* R: value type - SNDRV_CTL_ELEM_TYPE_* */
> unsigned int access; /* R: value access (bitmask) - SNDRV_CTL_ELEM_ACCESS_* */
> unsigned int count; /* count of values */
> - __kernel_pid_t owner; /* owner's PID of this control */
> + pid_t owner; /* owner's PID of this control */
> union {
> struct {
> long min; /* R: minimum value */
> --
> 2.7.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
