Hi, On 2/9/2016 12:52 AM, Mark Brown wrote:
On Fri, Feb 05, 2016 at 04:32:45PM +0800, John Hsu wrote:switch (event) { case SND_SOC_DAPM_POST_PMU: /* Prevent startup click by letting charge pump to ramp up */ msleep(10); + regmap_update_bits(nau8825->regmap, NAU8825_REG_CHARGE_PUMP, + NAU8825_JAMNODCLOW, NAU8825_JAMNODCLOW); + break; + case SND_SOC_DAPM_PRE_PMD: + regmap_update_bits(nau8825->regmap, NAU8825_REG_CLASSG_CTRL, + NAU8825_CLASSG_EN, 0); + break; + case SND_SOC_DAPM_POST_PMD: + regmap_update_bits(nau8825->regmap, NAU8825_REG_BOOST, + NAU8825_HP_BOOST_DIS, 0); break;This is really hard to follow, the enables and disables here don't match up (I see that at least some of these are handled by other widgets on the other path). I at least need some words explaining what the intended effect of the change is.
OK, we can arrange it again to avoid the configuration overlap. It's no problem to add more explaining. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
