Hi Mark, On Fri, 2016-02-19 at 23:37 +0800, Mark Brown wrote: > On Fri, Feb 19, 2016 at 10:35:59AM +0800, PC Liao wrote: > > > @@ -3,3 +3,4 @@ obj-$(CONFIG_SND_SOC_MEDIATEK) += mtk-afe-pcm.o > > # Machine support > > obj-$(CONFIG_SND_SOC_MT8173_MAX98090) += mt8173-max98090.o > > obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173-rt5650-rt5676.o > > +obj-$(CONFIG_SND_SOC_MT8173_RT5650) += mt8173-rt5650.o > > Why is this not covered by (or coverable by) the existinng RT5650-RT5657 > driver? Thanks for your review. Because they are different boards and have some differences like HW configuration and mixer control, we want to separate machine driver clearly. Otherwise, I think I will upload this change to new version for more clearly. diff --git a/sound/soc/mediatek/Makefile b/sound/soc/mediatek/Makefile index bcdcb06..dcb1440 100644 --- a/sound/soc/mediatek/Makefile +++ b/sound/soc/mediatek/Makefile @@ -2,5 +2,5 @@ obj-$(CONFIG_SND_SOC_MEDIATEK) += mtk-afe-pcm.o # Machine support obj-$(CONFIG_SND_SOC_MT8173_MAX98090) += mt8173-max98090.o -obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173-rt5650-rt5676.o obj-$(CONFIG_SND_SOC_MT8173_RT5650) += mt8173-rt5650.o +obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173-rt5650-rt5676.o _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel