Re: [PATCH] Revert "ASoC: fsl_ssi: remove explicit register defaults"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21.02.2016 15:35, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> Commit 5c408fee2546 ("ASoC: fsl_ssi: remove explicit register defaults")
> causes the driver to fail to probe:
> 
> fsl-ssi-dai 2028000.ssi: No cache defaults, reading back from HW
> fsl-ssi-dai 2028000.ssi: Failed to init register map
> fsl-ssi-dai: probe of 2028000.ssi failed with error -22
> 
> , so revert this commit.
> 
> Cc: Maciej S. Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>
> Reported-by: Mika Penttilä <mika.penttila@xxxxxxxxxxxx> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
> Maciej,
> 
> As this currently breaks SSI on 4.5-rc we should better revert it for
> this cycle.
> 
> We can then add it back to 4.7 when Mark's patch 3245d460a1eb55 
> ("regmap: cache: Fall back to register by register read for cache defaults")
> will be available and then the driver will work fine with your patch.

While I see no problem with delaying this patch to next kernel wouldn't
it be easier to simply merge the regmap change as a fix as you
had suggested previously?

Maciej

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux