On Sat, 13 Feb 2016 09:08:06 +0100,
Andrey Konovalov wrote:
>
> The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
> when tearing down the rawmidi interface. So we shouldn't try to free it
> in snd_usbmidi_create() after having registered the rawmidi interface.
>
> Found by KASAN.
>
> Acked-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxx>
Thanks, applied now with Cc to stable.
Takashi
> ---
> sound/usb/midi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index cc39f63..007cf58 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
> else
> err = snd_usbmidi_create_endpoints(umidi, endpoints);
> if (err < 0) {
> - snd_usbmidi_free(umidi);
> return err;
> }
>
> --
> 1.9.1
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
