Re: [PATCH] ASoC: rt5645: add "coreboot" to dmi_system_id list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 01, 2016 at 01:21:18PM +0800, Bard Liao wrote:

> +	{
> +		.ident = "Google Chrome",
> +		.matches = {
> +			DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
> +		},
> +	},

While coreboot is most commonly seen in ChromeOS systems it's not unique
to them so this seems likely to generate false positives.  Since the
target for this change is internal-only development hardware it doesn't
seem unreasonable to expect people to be able to keep changes like
device ID updates internally.  This is one of the many costs of BIOSes
that require us to do such DMI hacks, it'd be much better to improve the
firmware and the driver so they can specify required properties directly
rather than relying on DMI.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux