Re: [PATCH alsa-plugins] pph: include config.h from rate_speexrate.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Jan 2016 12:45:51 +0100,
Tanu Kaskinen wrote:
> 
> Fixes compilation against libspeexdsp 1.2rc3.
> 
> rate_speexrate.c includes speex_resampler.h, which depends on config.h
> by referencing the HAVE_SPEEX_SPEEXDSP_TYPES_H macro. AFAIK it's not
> a good idea to include config.h from headers (I don't know/remember
> why, though), which is why I include config.h from rate_speexrate.c
> instead of speex_resampler.h.
> 
> Signed-off-by: Tanu Kaskinen <tanuk@xxxxxx>

Applied, thanks.


Takashi

> ---
>  pph/rate_speexrate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pph/rate_speexrate.c b/pph/rate_speexrate.c
> index 0a1325c..8fc4cef 100644
> --- a/pph/rate_speexrate.c
> +++ b/pph/rate_speexrate.c
> @@ -28,6 +28,7 @@
>     POSSIBILITY OF SUCH DAMAGE.
>  */
>  
> +#include "config.h"
>  #include <stdio.h>
>  #include <alsa/asoundlib.h>
>  #include <alsa/pcm_rate.h>
> -- 
> 2.7.0.rc3
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux