On Sat, Jan 16, 2016 at 01:25:29PM +0100, Sergej Sawazki wrote: > +static unsigned int _wm8741_volume_get(struct snd_soc_codec *codec, > + struct soc_mixer_control *mc, unsigned int lsb_reg) All the readback stuff looks entirely generic and should be using generic functions. If they don't exist add them to the core. > +static int wm8741_volume_set(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ Similarly for the set stuff, there's nothing visibly device specific here.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel