On Fri, 08 Jan 2016 14:59:50 +0100, Vinod Koul wrote: > > On Fri, Jan 08, 2016 at 01:42:17PM +0000, Mark Brown wrote: > > On Wed, Dec 09, 2015 at 09:46:11PM +0530, Subhransu S. Prusty wrote: > > > > > This patch uses i915 component framework to register for hotplug > > > notification. And once it identifies valid pin sense and valid eld, > > > > You say this patch uses the i915 component framework but... > > > > > + if (pin->eld.monitor_present && pin->eld.eld_valid) { > > > + /* TODO: Use i915 cmpnt framework when available */ > > > + if (hdac_hdmi_get_eld(&edev->hdac, pin->nid, > > > > ...that's a TODO according to the code? > > ah sorry, Shubranshu meant use i915 eld presence fwk when available. > Takashi was working on it so we will convert this to use shiny new > framework a bit later :) FYI, the framework has been already merged to for-next branch. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel