Re: [PATCH 4/4] ALSA: hda - hdmi monitor hotplug support for dynamic pcm assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 31 Dec 2015 02:22:22 +0100,
libin.yang@xxxxxxxxxxxxxxx wrote:
> 
> From: Libin Yang <libin.yang@xxxxxxxxxxxxxxx>
> 
> This patch adds the support for monitor hotplug of dynamic pcm assignment.
> 
> 1. unsol_event enabling
>  - For codec_has_acomp, unsol_event is disabled.
>  - For !codec_has_acomp && !dyn_pcm_assign, use the hda_jack helper to
>    enable unsol_event
>  - For !codec_has_acomp && dyn_pcm_assign, enable unsol_event with verb
>    directly
> 
> 2. unsol_event handling
>  - For !dyn_pcm_assign, use hda_jack helper to report the event
>  - For dyn_pcm_assign, use snd_jack_report() directly

I guess we can reduce lots of codes if ignoring the case with
dyn_pcm_assign but without audio component?  If so, for simplicity, we
can limit dyn_pcm_assign only tied with audio component.  Just add a
WARN_ON() in such a case.  Although the functionality is somehow
unrelated, the actual testing and coding is more targeted with Intel
chips that are only with audio component.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux