> -----Original Message----- > From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] > Sent: Tuesday, December 22, 2015 12:19 AM > To: Mark Brown > Cc: Bard Liao; alsa-devel@xxxxxxxxxxxxxxxx; Jack Yu > Subject: Re: [PATCH 12/19] ASoC: codec: rt5651: add ACPI and > OF support > > On 12/19/15 5:50 AM, Mark Brown wrote: > > On Thu, Dec 17, 2015 at 08:35:49PM -0600, Pierre-Louis Bossart wrote: > > > >> +#if defined(CONFIG_OF) > >> +static const struct of_device_id rt5651_of_match[] = { > >> + { .compatible = "realtek,rt5651", }, > >> + {}, > >> +}; > >> +MODULE_DEVICE_TABLE(of, rt5651_of_match); #endif > > > > You need a binding document for new DT bindings. > > Ah yes. > I added ACPI and OF support through copy-paste and s/rt5640/rt5651/, but > I can only test ACPI and wouldn't know what bindings are required so will > remove this OF part in the next batch. > Bard and team if you want to add OF support please go ahead. Sure, I will do it. > > > > ------Please consider the environment before printing this e-mail. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel