> -----Original Message----- > From: Takashi Iwai [mailto:tiwai@xxxxxxx] > Sent: Friday, December 11, 2015 6:59 PM > To: libin.yang@xxxxxxxxxxxxxxx > Cc: alsa-devel@xxxxxxxxxxxxxxxx; Lin, Mengdong; Yang, Libin > Subject: Re: [PATCH v3 5/5] ALSA: hda - hdmi setup pin when > monitor hotplug in pcm dynamic assignment mode > > On Thu, 10 Dec 2015 02:52:12 +0100, > libin.yang@xxxxxxxxxxxxxxx wrote: > > > > From: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > > > > Setup pin configuration when monitor is hotplugged > > in pcm dynamic assignment if the PCM is in open state. > > > > When monitor is disconnect, The pin will be reset. > > > > Signed-off-by: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > > --- > > sound/pci/hda/hda_codec.h | 1 + > > sound/pci/hda/patch_hdmi.c | 82 > +++++++++++++++++++++++++++++++++++++++++++--- > > 2 files changed, 79 insertions(+), 4 deletions(-) > > > > diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h > > index 373fcad..ee97401 100644 > > --- a/sound/pci/hda/hda_codec.h > > +++ b/sound/pci/hda/hda_codec.h > > @@ -167,6 +167,7 @@ enum { > > /* for PCM creation */ > > struct hda_pcm { > > char *name; > > + bool in_use; > > No need to add such a flag in a common object. (And actually it's > wrong to add here, it should be per stream.) > > The check is needed only for HDMI/DP, thus it can be put in > hdmi_spec. And it can be a bit flag protected via your new pcm_lock. Yes, I will put it in hdmi_spec. Regards, Libin > > > Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
