On Thu, Dec 10, 2015 at 11:21:25AM +0800, Zidan Wang wrote:
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 8832901..a55a7de 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -564,6 +564,17 @@ static int fsl_sai_trigger(struct snd_pcm_substream *substream, int cmd,
> FSL_SAI_CSR_FR, FSL_SAI_CSR_FR);
> regmap_update_bits(sai->regmap, FSL_SAI_RCSR,
> FSL_SAI_CSR_FR, FSL_SAI_CSR_FR);
> +
> + if (!sai->is_slave_mode) {
It'd be nicer to add a simple comment to describe the errata here.
Users may have no idea about this abrupt reset as we do.
You may add my ack to your next version:
Acked-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
> + /* Software Reset for both Tx and Rx */
> + regmap_write(sai->regmap,
> + FSL_SAI_TCSR, FSL_SAI_CSR_SR);
> + regmap_write(sai->regmap,
> + FSL_SAI_RCSR, FSL_SAI_CSR_SR);
> + /* Clear SR bit to finish the reset */
> + regmap_write(sai->regmap, FSL_SAI_TCSR, 0);
> + regmap_write(sai->regmap, FSL_SAI_RCSR, 0);
> + }
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
