On Tue, 08 Dec 2015 17:53:04 +0100,
Gabriele Martino wrote:
>
> The Alienware 17 (2015) has the same card and pin configuration of the
> Alienware 15, so the same quirks must be applied.
>
> Signed-off-by: Gabriele Martino <g.martino@xxxxxxx>
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index f8a12ca..41e8848 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -760,7 +760,8 @@ struct ca0132_spec {
> */
> enum {
> QUIRK_NONE,
> - QUIRK_ALIENWARE,
> + QUIRK_ALIENWARE_15,
> + QUIRK_ALIENWARE_17,
> };
>
> static const struct hda_pintbl alienware_pincfgs[] = {
> @@ -778,7 +779,8 @@ static const struct hda_pintbl alienware_pincfgs[] = {
> };
>
> static const struct snd_pci_quirk ca0132_quirks[] = {
> - SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15", QUIRK_ALIENWARE),
> + SND_PCI_QUIRK(0x1028, 0x0685, "Alienware 15 2015", QUIRK_ALIENWARE_15),
> + SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE_17),
> {}
> };
>
> @@ -4631,8 +4633,8 @@ static void ca0132_config(struct hda_codec *codec)
> spec->multiout.num_dacs = 3;
> spec->multiout.max_channels = 2;
>
> - if (spec->quirk == QUIRK_ALIENWARE) {
> - codec_dbg(codec, "ca0132_config: QUIRK_ALIENWARE applied.\n");
> + if (spec->quirk == QUIRK_ALIENWARE_15 || spec->quirk == QUIRK_ALIENWARE_17) {
If it's the very same quirk, you don't have to invent a new name, but
just add a line:
SND_PCI_QUIRK(0x1028, 0x0688, "Alienware 17 2015", QUIRK_ALIENWARE),
So it'd be a oneliner. Could you respin and resubmit the patch?
thanks,
Takashi
> + codec_dbg(codec, "ca0132_config: QUIRK_ALIENWARE_* applied.\n");
> snd_hda_apply_pincfgs(codec, alienware_pincfgs);
>
> spec->num_outputs = 2;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
