On Mon, Nov 23, 2015 at 11:04:04AM -0500, mengdong.lin@xxxxxxxxxxxxxxx wrote: A couple of small things but otherwise this looks fine: > + struct snd_soc_dai_link *dai_link; /* predefined links only */ > + int num_links; /* predefined links only */ > + struct list_head dai_link_list; /* all links */ > + int num_dai_links; Why are we keeping a count of num_dai_links? I can't see any users. > + /* add predefined DAI links to the list */ > + for (i = 0; i < card->num_links; i++) > + snd_soc_add_dai_link(card, card->dai_link+i); Missing spaces around the + here.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel