> -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: Wednesday, November 25, 2015 8:02 PM > To: Bard Liao > Cc: lgirdwood@xxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; lars@xxxxxxxxxx; > Flove; Oder Chiou; John Lin; Luke_Yin@xxxxxxxx > Subject: Re: [PATCH] ASoC: rt5645: Add dmi_system_id "Google Terra" > > On Tue, Nov 24, 2015 at 10:55:29AM +0800, Bard Liao wrote: > > > + { > > + .ident = "Google Terra", > > + .callback = strago_quirk_cb, > > + .matches = { > > + DMI_MATCH(DMI_PRODUCT_NAME, "Terra"), > > + }, > > + }, > > It might make more sense to just have a single entry for all these Google > platforms and extend this table rather than adding a complete new entry > for every platform - they're all the same and it'd make the table smaller. Totally agree. We are trying to simplify the code. The idea is using DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE") for all google project except a few projects with different HW design. We will use if else statement to match the projects with special HW design first and the general ones. Also, I think those can support DT/ACPI should have higher priority than DMI match, right? > > ------Please consider the environment before printing this e-mail. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
