Re: [RFC PATCH 1/2] ALSA: hda - add hda_dev_t typedef for DP MST audio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 03 Nov 2015 09:22:52 +0100,
libin.yang@xxxxxxxxxxxxxxx wrote:
> 
> From: Libin Yang <libin.yang@xxxxxxxxx>
> 
> Signed-off-by: Libin Yang <libin.yang@xxxxxxxxx>
> ---
>  include/sound/hdaudio.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index e2b712c..1f54964 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -15,6 +15,7 @@
>  
>  /* codec node id */
>  typedef u16 hda_nid_t;
> +typedef u8 hda_dev_t;

This isn't used in any ABI, so we don't have to define the type.
Just use int instead.

NID was defined there because it's used in ABI and it can represent
the purpose more clearly.  (Also at the early time of driver writing,
the size itself wasn't 100% clear; we started writing it before
HD-audio spec got solid.)


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux